Skip to content

Conversation

@ovitrif
Copy link
Collaborator

@ovitrif ovitrif commented May 7, 2025

Adds support to set fee rate for sending onchain transactions

  • Lightning service accepts satsPerVByte and converts to ldk-node's satsPerKwu
  • TransactionSpeed type for storage & UI, with mapping to get satsPerVByte value from FeeRate
  • LightningRepo sendOnChain accepts speed nullable param, resorting to user's default speed
  • UI improvements to Settings > General
  • Transaction Speed Settings Screen
  • Set Custom Fee Settings Screen
  • Reusable settings button row component

Preview

txSpeedSettings.mp4

@ovitrif ovitrif marked this pull request as ready for review May 8, 2025 09:45
@ovitrif ovitrif requested a review from jvsena42 May 8, 2025 09:45
Copy link
Member

@jvsena42 jvsena42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great progress! With this I can implement some missing features in the sending flow after finish the receive

@ovitrif ovitrif merged commit c33bf74 into master May 8, 2025
1 check passed
@ovitrif ovitrif deleted the feat/fee-rates branch May 8, 2025 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants